lib: refactor to remove optional chaining in events.js#36539
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
lib: refactor to remove optional chaining in events.js#36539RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
events
aduh95
reviewed
Dec 16, 2020
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Why would we want to remove optional chaining?
Member
Author
|
The reviewers in the referenced PR mentioned that it might have a performance impact and it hinders readability. |
Member
|
Since I left the original comment on the performance there have been a few benchmark runs that show the performance with the chaining is good! I'd go ahead and just leave this as is. |
Member
|
You can look at this pull request: #36524, optional chaining performance looks good. |
Member
Author
|
Thanks for letting me know. I'll try to add optional chaining to other modules then. |
RaisinTen
deleted the
lib/refactor-to-remove-optional-chaining-in-events.js
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #36528
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes